static/files/usd_to_crypto.py (3)

1-2: Remove unused import.

The sys module is imported but never used in the script.

Proposed fix

 import requests
-import sys

---

15-18: Use exception chaining for proper traceback preservation.

When re-raising an exception within an except block, use raise ... from err to preserve the original traceback context.

Proposed fix

         try:
             usd_amount = float(content)
         except ValueError:
-            raise ValueError("Input is not a valid number")
+            raise ValueError("Input is not a valid number") from None

---

26-32: Add defensive checks for API response structure.

The code assumes the API response contains bitcoin.usd and ethereum.usd keys. If the API response structure changes or returns unexpected data, this will raise a KeyError. Consider adding validation or using .get() with appropriate fallback handling.

Additionally, while unlikely, a price of 0 from the API would cause a ZeroDivisionError on lines 31-32.

Proposed fix with defensive checks

         data = response.json()
-        btc_price = data["bitcoin"]["usd"]
-        eth_price = data["ethereum"]["usd"]
+        
+        if "bitcoin" not in data or "usd" not in data.get("bitcoin", {}):
+            raise RuntimeError("API response missing bitcoin price data")
+        if "ethereum" not in data or "usd" not in data.get("ethereum", {}):
+            raise RuntimeError("API response missing ethereum price data")
+        
+        btc_price = data["bitcoin"]["usd"]
+        eth_price = data["ethereum"]["usd"]
+        
+        if btc_price <= 0 or eth_price <= 0:
+            raise RuntimeError("Invalid price data received from API")

         # Calculate how much BTC and ETH can be bought
         btc_amount = usd_amount / btc_price
         eth_amount = usd_amount / eth_price